-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 2977 #3798
Issue 2977 #3798
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Keep on it with #3768 if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I just noticed that this solution causes one bug. Problem is that when you go into opening details from a specific WG page, the back button will always transfer you to general openings instead of given WG ones.
Two cases have to be considered before pushing customLink
to the stack:
- Whether
history.length
is bigger than 2 (if stack eq1
then, the user clicks the link and get redirected, if stack eq2
there is a possibility that the user opened a new tab in the browser and paste in the link - Another possibility is that the user clicks on the URL to the openings list and then clicks on the given opening, in that case, checking for stack length will fail (stack length will equal
2
, butgoBack
should be invoked anyway), but we can check the current action on the history. I see that when you paste the URL or click on the link action will eqPOP
while if you navigate from Pioneer forward (Opening list -> Opening details) it will bePUSH
Integrating these two rules should do the work. WDYT?
I just made modifications based on your second suggestion. I think tracking the link action is all that's needed. I tested out for those cases you mentioned, and they work fine now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! tested entering opening details from /working-groups/openings
and /working-groups/forum
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does it have all the types changes here? I guess this can be done in a separate change if needed.
You are right, didn't look at the code. @vrrayz resubmit the fix on a new branch please. |
alright |
@traumschule I just resubmitted in this branch |
Back button on openings now list to list page as requested from this this issue